-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed PostgresDriver (for jvmMain) to correctly make use of the connection pool. #54
base: main
Are you sure you want to change the base?
Fixed PostgresDriver (for jvmMain) to correctly make use of the connection pool. #54
Conversation
…pool. Also, some minor changes for logging in jvmTest.
…pool. Also, some minor changes for logging in jvmTest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your implementations!
I haven't noticed that r2dbc wasn't using a pool, so I'll have to test the before and after when I can. Please keep in mind that I'll most likely be away from keyboard for a few days.
Cheers!
src/jvmMain/kotlin/io/github/moreirasantos/pgkn/PostgresDriver.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Miguel <[email protected]>
I realized that isn't using the connection pool because I was reviewing the whole codebase in order to support transactions. Let me know about the comments above 😄 |
Indeed, that was my idea when adding r2dbc (having something to compare to). One thing that jumps out right away for example, is sending multiple SQL statements in one go, which r2dbc already supports and this interface kind of hides/limits that. |
Sure! So, I'll do the changes later on and in the next days I'll provide the implementation for the |
Hello! I just made the changes according to the conversation above. |
I just made the appropriate changes.
Before the code was using just a single connection. 😄