Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log image fix #3286

Merged
merged 31 commits into from
Jun 17, 2024
Merged

log image fix #3286

merged 31 commits into from
Jun 17, 2024

Conversation

jessechancy
Copy link
Contributor

What does this PR do?

Updates mlflow logger log_image to use the new API with time-dimension. This will enable viewing the images in MLflow

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@jessechancy jessechancy requested a review from a team as a code owner May 14, 2024 21:29
@jessechancy
log image fix
f700f90 
Signed-off-by: Jesse Chan <[email protected]>
@jessechancy
fixed log image tests
deed464 
Signed-off-by: Jesse Chan <[email protected]>
@milocress milocress requested a review from a team as a code owner June 12, 2024 21:10
@milocress milocress requested a review from mvpatel2000 June 13, 2024 22:50
milocress
milocress previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@milocress milocress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. @mvpatel2000 can you take another look to make sure everything is shipshape? 🚢 🚢 🚢

mvpatel2000
mvpatel2000 reviewed Jun 14, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
composer/algorithms/utils/augmentation_primitives.py Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 dismissed milocress’s stale review June 14, 2024 02:28

Dismissing since you did changes on PR

mvpatel2000
mvpatel2000 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvpatel2000 mvpatel2000 merged commit 3859366 into mosaicml:dev Jun 17, 2024
17 checks passed
mvpatel2000 added a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@jessechancy @dakinggg
@milocress @mvpatel2000
log image fix (mosaicml#3286)
e2ea512 
* log image fix

Signed-off-by: Jesse Chan <[email protected]>

* fixed log image tests

Signed-off-by: Jesse Chan <[email protected]>

* linter

Signed-off-by: Jesse Chan <[email protected]>

* add simd requirement

* post0?

* versioning yada yada yada

* guh

* import fix?

* update deps

* fix

* fix II

* remove other dependency

* debug statement, remove

* post1?!

* build from source

* whitespace?

* use pillow

* delete a unit test and ignore some types

* s/type/pyright

* formatting

* formatting

* ignore more stuff

* Apply suggestions from code review

* remove rest

* Update setup.py

Co-authored-by: Mihir Patel <[email protected]>

* try no ignore

* remove intenum

---------

Signed-off-by: Jesse Chan <[email protected]>
Co-authored-by: Daniel King <[email protected]>
Co-authored-by: Milo Cress <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000 added a commit that referenced this pull request Jul 21, 2024
@jessechancy @dakinggg
@milocress @mvpatel2000
log image fix (#3286)
1dfd3bc 
* log image fix

Signed-off-by: Jesse Chan <[email protected]>

* fixed log image tests

Signed-off-by: Jesse Chan <[email protected]>

* linter

Signed-off-by: Jesse Chan <[email protected]>

* add simd requirement

* post0?

* versioning yada yada yada

* guh

* import fix?

* update deps

* fix

* fix II

* remove other dependency

* debug statement, remove

* post1?!

* build from source

* whitespace?

* use pillow

* delete a unit test and ignore some types

* s/type/pyright

* formatting

* formatting

* ignore more stuff

* Apply suggestions from code review

* remove rest

* Update setup.py

Co-authored-by: Mihir Patel <[email protected]>

* try no ignore

* remove intenum

---------

Signed-off-by: Jesse Chan <[email protected]>
Co-authored-by: Daniel King <[email protected]>
Co-authored-by: Milo Cress <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milocress milocress milocress left review comments

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessechancy @mvpatel2000 @milocress @dakinggg