Skip to content

Sketcher: fix seg-fault on loading sketch with redundant constraints #1676

Sketcher: fix seg-fault on loading sketch with redundant constraints

Sketcher: fix seg-fault on loading sketch with redundant constraints #1676

Triggered via push January 26, 2025 13:58
Status Success
Total duration 2h 46m 56s
Artifacts 8

CI_master.yml

on: push
Prepare  /  Prepare
7s
Prepare / Prepare
Matrix: Pixi / build_with_pixi
WrapUp  /  WrapUp
3s
WrapUp / WrapUp
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 72 warnings
Lint / Lint
Process completed with exit code 1.
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L389
Possibly using variable 'NetworkManager' before assignment (possibly-used-before-assignment)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L396
Possibly using variable 'requests' before assignment (possibly-used-before-assignment)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L401
Possibly using variable 'ssl' before assignment (possibly-used-before-assignment)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L402
Using variable 'urllib' before assignment (used-before-assignment)
Lint / Lint
Process completed with exit code 1.
Lint / Lint
Process completed with exit code 1.
Prepare / Prepare
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint / Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L1
would reformat src/Mod/AddonManager/addonmanager_utilities.py
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L452
Line too long (120/100) (line-too-long)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L453
Line too long (114/100) (line-too-long)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L471
Line too long (112/100) (line-too-long)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L37
Reimport 're' (imported line 32) (reimported)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L38
Reimport 'ctypes' (imported line 29) (reimported)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L39
Reimport 'Optional' (imported line 28) (reimported)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L39
Reimport 'Any' (imported line 28) (reimported)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L49
Deprecated module 'PySide2' (deprecated-module)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L105
Missing function or method docstring (missing-function-docstring)
Lint / Lint: src/Mod/AddonManager/addonmanager_utilities.py#L110
Using deprecated argument onerror of method rmtree() (deprecated-argument)
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L1777
Using C-style cast. Use static_cast<double>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L1795
Using deprecated casting style. Use static_cast<int>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L1849
Using deprecated casting style. Use static_cast<int>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L1853
Using deprecated casting style. Use static_cast<int>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L1900
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L1983
Using deprecated casting style. Use static_cast<int>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L2586
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L2596
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L2625
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L2644
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
Lint / Lint
variable 'count' set but not used [-Wunused-but-set-variable]
Lint / Lint
variable 'nsuper_et' set but not used [-Wunused-but-set-variable]
Lint / Lint
variable 'nsuper_et_post' set but not used [-Wunused-but-set-variable]
Lint / Lint
Pass small and trivially-copyable type by value (const float &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const float &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const double &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const double &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const float &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const float &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const double &) [-Wclazy-function-args-by-value]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L249
parameter 'str' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L250
parameter 'str' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L341
conditional operator is used as sub-expression of parent conditional operator, refrain from using nested conditional operators [readability-avoid-nested-conditional-operator]
Lint / Lint
note: parent conditional operator here
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L352
do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L362
do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L370
the parameter 'constraintgroups' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L390
the parameter 'constraintset' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L412
use range-based for loop instead [modernize-loop-convert]
Lint / Lint: src/Mod/Sketcher/App/planegcs/GCS.cpp#L464
initializer for member 'c2p' is redundant [readability-redundant-member-init]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L491
implicit conversion from 'const int64_t' (aka 'const long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L203
implicit conversion from 'const int32_t' (aka 'const int') to 'float' changes value from 2147483647 to 2147483648 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L215
implicit conversion from 'const uint32_t' (aka 'const unsigned int') to 'float' changes value from 4294967295 to 4294967296 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L227
implicit conversion from 'const int64_t' (aka 'const long long') to 'float' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L227
implicit conversion from 'const int64_t' (aka 'const long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L1787
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L1788
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L1983
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L2029
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L1992
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L2014
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L2022
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L2168
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/Objects.hxx#L2191
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Pixi / build_with_pixi (ubuntu-latest): src/CXX/Python3/cxxsupport.cxx#L49
'Py_UNICODE' is deprecated [-Wdeprecated-declarations]
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Pixi / build_with_pixi (windows-latest)
No files were found with the provided path: D:\a\FreeCAD\FreeCAD/logs/ /var/crash/*FreeCAD*. No artifacts will be uploaded.
Pixi / build_with_pixi (windows-latest)
'=': conversion from 'size_t' to '_Ty', possible loss of data
Pixi / build_with_pixi (windows-latest)
No files were found with the provided path: D:\a\FreeCAD\FreeCAD/report/Pixi-12975301468-windows-latest-report.md. No artifacts will be uploaded.
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
WrapUp / WrapUp
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
Lint-12975301468-Logs
40.1 KB
Pixi-12975301468-macos-latest-Logs
45.7 KB
Pixi-12975301468-macos-latest-report.md
406 Bytes
Pixi-12975301468-ubuntu-latest-Logs
45.8 KB
Pixi-12975301468-ubuntu-latest-report.md
591 Bytes
Prepare-12975301468-Logs
4.36 KB
Ubuntu_20-04-12975301468-Logs
187 KB
Windows-12975301468-Logs
2.82 MB