Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cors): allowOriginStringMatch & allowMethods are required #823

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

spacewander
Copy link
Member

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (a065daf) to head (2032aa3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
types/plugins/cors/config.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   85.92%   85.58%   -0.34%     
==========================================
  Files         141      141              
  Lines        8357     8369      +12     
==========================================
- Hits         7181     7163      -18     
- Misses        920      947      +27     
- Partials      256      259       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
@spacewander spacewander marked this pull request as ready for review December 13, 2024 06:43
@spacewander spacewander merged commit 7bc0598 into main Dec 16, 2024
20 checks passed
@spacewander spacewander deleted the 1213 branch December 16, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant