Skip to content

Commit

Permalink
Mitigate cartesian path tests
Browse files Browse the repository at this point in the history
Signed-off-by: methylDragon <[email protected]>
  • Loading branch information
methylDragon committed Dec 29, 2024
1 parent 7c2d1e6 commit 5a40222
Showing 1 changed file with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ TEST_F(MoveGroupFixture, CartesianBestSeenExecutionTimePolicyChecks)
valid_plan.fraction = move_group_->computeCartesianPath(valid_msg.waypoints, valid_msg.max_step,
valid_msg.jump_threshold, valid_plan.solution);
#pragma GCC diagnostic pop
} while (valid_plan.fraction <= 0); // Sometimes the plan fails with the random pose.
} while (valid_plan.fraction <= 0 &&
valid_plan.solution.joint_trajectory.points.size() < 2); // Sometimes the plan fails with the random pose.

// Valid case, as control.
{
Expand Down Expand Up @@ -350,7 +351,7 @@ TEST_F(MoveGroupFixture, CartesianBestSeenExecutionTimePolicyWorks)
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
plan.fraction = move_group_->computeCartesianPath(msg.waypoints, msg.max_step, msg.jump_threshold, plan.solution);
#pragma GCC diagnostic pop
} while (plan.fraction <= -1 &&
} while (plan.fraction <= 0 &&
plan.solution.joint_trajectory.points.size() < 2); // Sometimes the plan fails with the random pose.

do
Expand All @@ -366,8 +367,8 @@ TEST_F(MoveGroupFixture, CartesianBestSeenExecutionTimePolicyWorks)
another_plan.fraction = move_group_->computeCartesianPath(another_msg.waypoints, another_msg.max_step,
another_msg.jump_threshold, another_plan.solution);
#pragma GCC diagnostic pop
} while (another_plan.fraction <= -1 &&
plan.solution.joint_trajectory.points.size() < 2); // Sometimes the plan fails with the random pose.
} while (another_plan.fraction <= 0 &&
another_plan.solution.joint_trajectory.points.size() < 2); // Sometimes the plan fails with the random pose.

// Ensure that the entries are valid.
{
Expand Down

0 comments on commit 5a40222

Please sign in to comment.