Fix planning_scene_monitor sync when passed empty robot state (#3187)

* Fix planning_scene_monitor sync when passed empty robot state * address review * check for null current_state_monitor_ and fall back to diff scene_ if needed --------- Co-authored-by: Sebastian Jahr <[email protected]>
moveit · Jan 7, 2025 · 80c7f61 · 80c7f61
1 parent 7390ebc
commit 80c7f61
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/moveit_ros/planning/planning_scene_monitor/src/planning_scene_monitor.cpp b/moveit_ros/planning/planning_scene_monitor/src/planning_scene_monitor.cpp
@@ -740,6 +740,21 @@ bool PlanningSceneMonitor::newPlanningSceneMessage(const moveit_msgs::msg::Plann
 
     if (!scene.is_diff && parent_scene_)
     {
+      // if the scene does not contain a robot state then use the latest known values for the robot state
+      // so that we are not updating the scene with stale values.
+      if (scene.robot_state.joint_state.name.empty())
+      {
+        // if we have a valid current_state_monitor_ with complete state use the latest data otherwise try
+        // to use the maintained (diff) scene_ which may fall back to the parent_scene_ data and not update.
+        if (current_state_monitor_ && current_state_monitor_->haveCompleteState())
+        {
+          parent_scene_->setCurrentState(*current_state_monitor_->getCurrentState());
+        }
+        else
+        {
+          parent_scene_->setCurrentState(scene_->getCurrentState());
+        }
+      }
       // clear maintained (diff) scene_ and set the full new scene in parent_scene_ instead
       scene_->clearDiffs();
       result = parent_scene_->setPlanningSceneMsg(scene);