-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fuzzy-matching Trajectory Cache 🔥 #2838
Merged
henningkayser
merged 27 commits into
moveit:main
from
methylDragon:ch3/trajectory_cache
Aug 26, 2024
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
99d50cd
Implement trajectory cache
methylDragon 3025ed6
Add README
methylDragon d7095ba
Move test cpp to test directory
methylDragon 728dce2
Clean up logging and comments
methylDragon 7341e64
Use move_group node for time
methylDragon aa05365
Add and use logger
methylDragon cb8ab14
Use new move_group accessors
methylDragon deef7e0
Coerce variable and method names to style
methylDragon 7bf9129
Formatting pass
methylDragon cec778c
Add docstrings
methylDragon 6222846
Add ability to sort in descending order
methylDragon 10c6ac3
Add RFE for custom cost functions
methylDragon 692f562
Formatting pass
methylDragon 3199c33
Fix build for downstream packages
methylDragon ac50316
Always get some workspace frame ID
methylDragon 5a54628
Always get some cartesian path request frame ID
methylDragon caa4669
Fix tests
methylDragon 8b04e2f
Add const qualifiers as appropriate
methylDragon cf980c1
Add accessors, and support for preserving K plans
methylDragon cefceca
Edit docs and rename puts to inserts
methylDragon 307fa98
Make clang tidy happy
methylDragon 70fc487
Fix CMakeLists.txt
methylDragon d12ad95
Make getters const
methylDragon 5e4a622
Clarify frame ID utils docstrings
methylDragon 9a59882
Elaborate on trajectory cache benefits
methylDragon 85aa3f7
Fix CHANGELOG, and make library shared
methylDragon ce6f6eb
Merge branch 'main' into ch3/trajectory_cache
sjahr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
Changelog for package moveit_ros_trajectory_cache | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
0.1.0 (2024-05-17) | ||
------------------ | ||
* Add ``moveit_ros_trajectory_cache`` package for trajectory caching. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
cmake_minimum_required(VERSION 3.22) | ||
project(moveit_ros_trajectory_cache) | ||
|
||
# Common cmake code applied to all moveit packages | ||
find_package(moveit_common REQUIRED) | ||
moveit_package() | ||
|
||
find_package(ament_cmake REQUIRED) | ||
find_package(geometry_msgs REQUIRED) | ||
find_package(moveit_ros_planning_interface REQUIRED) | ||
find_package(moveit_ros_warehouse REQUIRED) | ||
find_package(rclcpp REQUIRED) | ||
find_package(tf2 REQUIRED) | ||
find_package(tf2_ros REQUIRED) | ||
find_package(trajectory_msgs REQUIRED) | ||
find_package(warehouse_ros REQUIRED) | ||
|
||
include(GenerateExportHeader) | ||
include_directories(include) | ||
|
||
set(TRAJECTORY_CACHE_DEPENDENCIES | ||
geometry_msgs | ||
moveit_ros_planning_interface | ||
moveit_ros_warehouse | ||
rclcpp | ||
tf2 | ||
tf2_ros | ||
trajectory_msgs | ||
warehouse_ros) | ||
|
||
# Trajectory cache library | ||
add_library(moveit_ros_trajectory_cache_lib SHARED src/trajectory_cache.cpp) | ||
generate_export_header(moveit_ros_trajectory_cache_lib) | ||
target_include_directories( | ||
moveit_ros_trajectory_cache_lib | ||
PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include> | ||
$<INSTALL_INTERFACE:include/moveit_ros_trajectory_cache>) | ||
ament_target_dependencies(moveit_ros_trajectory_cache_lib | ||
${TRAJECTORY_CACHE_DEPENDENCIES}) | ||
|
||
install( | ||
TARGETS moveit_ros_trajectory_cache_lib | ||
EXPORT moveit_ros_trajectory_cacheTargets | ||
LIBRARY DESTINATION lib | ||
ARCHIVE DESTINATION lib | ||
RUNTIME DESTINATION bin | ||
INCLUDES | ||
DESTINATION include/moveit_ros_trajectory_cache) | ||
|
||
install(DIRECTORY include/ DESTINATION include/moveit_ros_trajectory_cache) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/moveit_ros_trajectory_cache_lib_export.h | ||
DESTINATION include/moveit_ros_trajectory_cache) | ||
|
||
if(BUILD_TESTING) | ||
find_package(ament_cmake_pytest REQUIRED) | ||
find_package(launch_testing_ament_cmake REQUIRED) | ||
find_package(rmf_utils REQUIRED) | ||
find_package(warehouse_ros_sqlite REQUIRED) | ||
|
||
# This test executable is run by the pytest_test, since a node is required for | ||
# testing move groups | ||
add_executable(test_trajectory_cache test/test_trajectory_cache.cpp) | ||
target_link_libraries(test_trajectory_cache moveit_ros_trajectory_cache_lib) | ||
ament_target_dependencies(test_trajectory_cache warehouse_ros_sqlite) | ||
|
||
install(TARGETS test_trajectory_cache RUNTIME DESTINATION lib/${PROJECT_NAME}) | ||
|
||
ament_add_pytest_test( | ||
test_trajectory_cache_py "test/test_trajectory_cache.py" WORKING_DIRECTORY | ||
"${CMAKE_CURRENT_BINARY_DIR}") | ||
|
||
endif() | ||
|
||
ament_export_targets(moveit_ros_trajectory_cacheTargets HAS_LIBRARY_TARGET) | ||
ament_export_dependencies(${TRAJECTORY_CACHE_DEPENDENCIES}) | ||
ament_package() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,136 @@ | ||
# Trajectory Cache | ||
|
||
``` | ||
* This cache does NOT support collision detection! | ||
* Plans will be put into and fetched from the cache IGNORING collision. | ||
* If your planning scene is expected to change between cache lookups, do NOT | ||
* use this cache, fetched plans are likely to result in collision then. | ||
* | ||
* To handle collisions this class will need to hash the planning scene world | ||
* msg (after zeroing out std_msgs/Header timestamps and sequences) and do an | ||
* appropriate lookup, or otherwise find a way to determine that a planning scene | ||
* is "less than" or "in range of" another (e.g. checking that every obstacle/mesh | ||
* exists within the other scene's). (very out of scope) | ||
``` | ||
|
||
A trajectory cache based on [`warehouse_ros`](https://github.com/moveit/warehouse_ros) for the move_group planning interface that supports fuzzy lookup for `MotionPlanRequest` and `GetCartesianPath` requests and trajectories. | ||
|
||
The cache allows you to insert trajectories and fetch keyed fuzzily on the following: | ||
|
||
- Starting robot (joint) state | ||
- Planning request constraints | ||
- This includes ALL joint, position, and orientation constraints! | ||
- And also workspace parameters, and some others. | ||
- Planning request goal parameters | ||
|
||
It works generically for an arbitrary number of joints, across any number of move_groups. | ||
|
||
Furthermore, the strictness of the fuzzy lookup can be configured for start and goal conditions. | ||
|
||
## Citations | ||
|
||
If you use this package in your work, please cite it using the following: | ||
|
||
``` | ||
@software{ong_2024_11215428, | ||
author = {Ong, Brandon}, | ||
title = {A Fuzzy-Matching Trajectory Cache for MoveIt 2}, | ||
month = may, | ||
year = 2024, | ||
publisher = {GitHub}, | ||
version = {0.1.0}, | ||
doi = {10.5281/zenodo.11215428}, | ||
url = {https://doi.org/10.5281/zenodo.11215428} | ||
} | ||
``` | ||
|
||
## Example usage | ||
|
||
```cpp | ||
// Be sure to set some relevant ROS parameters: | ||
// Relevant ROS Parameters: | ||
// - `warehouse_plugin`: What database to use | ||
auto traj_cache = std::make_shared<TrajectoryCache>(node); | ||
traj_cache->init(/*db_host=*/":memory:", /*db_port=*/0, /*exact_match_precision=*/1e-6); | ||
|
||
auto fetched_trajectory = | ||
traj_cache->fetchBestMatchingTrajectory(*move_group_interface, robot_name, motion_plan_req_msg, | ||
_cache_start_match_tolerance, _cache_goal_match_tolerance, | ||
/*sort_by=*/"execution_time_s"); | ||
|
||
if (fetched_trajectory) | ||
{ | ||
// Great! We got a cache hit | ||
// Do something with the plan. | ||
} | ||
else | ||
{ | ||
// Plan... And put it for posterity! | ||
traj_cache->insertTrajectory( | ||
*interface, robot_name, std::move(plan_req_msg), std::move(res->result.trajectory), | ||
rclcpp::Duration(res->result.trajectory.joint_trajectory.points.back().time_from_start).seconds(), | ||
res->result.planning_time, /*prune_worse_trajectories=*/true); | ||
} | ||
``` | ||
|
||
It also has the following optimizations: | ||
- Separate caches for separate move groups | ||
- The cache does "canonicalization" of the poses to be relative to the planning frame to increase the chances of cache hits. | ||
- Configurable fuzzy lookup for the keys above. | ||
- It supports "overwriting" of worse trajectories with better trajectories | ||
- If a trajectory with keys extremely close to a pre-existing cache entry is inserted with a better planned execution time, the cache can delete all "worse" trajectories. | ||
- #IsThisMachineLearning | ||
- It also prunes the database and mitigates a lot of query slow-down as the cache grows | ||
|
||
## Working Principle | ||
|
||
If a plan request has start, goal, and constraint conditions that are "close enough" (configurable per request) to an entry in the cache, then the cached trajectory should be suitable (as long as obstacles have not changed). | ||
|
||
Goal fuzziness is a lot less lenient than start fuzziness by default. | ||
|
||
Finally, the databases are sharded by move group, and the constraints are added as columns in a name agnostic fashion (they are even somewhat robust to ordering, because they're sorted!) | ||
|
||
## Benefits | ||
|
||
A trajectory cache helps: | ||
- Cut down on planning time (especially for known moves) | ||
- Allows for consistent predictable behavior of used together with a stochastic planner | ||
- It effectively allows you to "freeze" a move | ||
sjahr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
These benefits come from the fact that the cache acts as a lookup table of plans that were already made for a given scenario and constraints, allowing the cache to be substituted for a planner call. The reuse of cached plans then allow you to get predictable execution behavior. | ||
|
||
A user may also choose when to leverage the cache (e.g. when planning moves from a static "home" position, or repetitive/cartesian moves) to get these benefits. | ||
|
||
Additionally, because the cache class has the ability to sort by planned execution time, over sufficient runs, the stochastic plans eventually converge to better and better plans (execution time wise). | ||
|
||
You may build abstractions on top of the class, for example, to expose the following behaviors: | ||
- `TrainingOverwrite`: Always plan, and write to cache, deleting all worse trajectories for "matching" cache keys | ||
- `TrainingAppendOnly`: Always plan, and always add to the cache. | ||
- `ExecuteBestEffort`: Rely on cache wherever possible, but plan otherwise. | ||
- `ExecuteReadOnly`: Only execute if cache hit occurred. | ||
|
||
You can see how such behaviors effectively model the "dev" and "deploy" phases of a robot deployment, and how they could be useful. | ||
|
||
## Best Practices | ||
|
||
- Since this cache does not yet support collisions, ensure the planning scene and obstacles remain static | ||
- Have looser start fuzziness, and stricter goal fuzziness | ||
- Move the robot to static known poses where possible before planning to increase the chances of a cache hit | ||
- Use the cache where repetitive, non-dynamic motion is likely to occur (e.g. known plans, short planned moves, etc.) | ||
|
||
## WARNING: The following are unsupported / RFE | ||
|
||
Since this is an initial release, the following features are unsupported because they were a little too difficult for the time I had to implement this. So I am leaving it to the community to help! | ||
|
||
- **!!! This cache does NOT support collision detection!** | ||
- Trajectories will be put into and fetched from the cache IGNORING collision. | ||
- If your planning scene is expected to change between cache lookups, do NOT use this cache, fetched trajectories are likely to result in collision then. | ||
- To handle collisions this class will need to hash the planning scene world msg (after zeroing out std_msgs/Header timestamps and sequences) and do an appropriate lookup, or do more complicated checks to see if the scene world is "close enough" or is a less obstructed version of the scene in the cache entry. | ||
- !!! This cache does NOT support keying on joint velocities and efforts. | ||
- The cache only keys on joint positions. | ||
- !!! This cache does NOT support multi-DOF joints. | ||
- !!! This cache does NOT support certain constraints | ||
- Including: path, constraint regions, everything related to collision. | ||
- The fuzzy lookup can't be configured on a per-joint basis. | ||
- Alternate ordinal lookup metrics for the cache | ||
- Currently only execution time is explicitly supported as a way to compare cache entries. Ideally we should be able to inject lambdas to save custom cache DB metadata to represent and sort on custom cost functions (e.g. minimum jerk, path length, etc.). (e.g. https://github.com/moveit/moveit2/pull/2153) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include moveit_common and apply the moveit_package() macro similar to here? https://github.com/moveit/moveit2/blob/main/moveit_ros/move_group/CMakeLists.txt#L4
It includes a bunch of build settings that we like to enable for all packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
85aa3f7