Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parameter namespacing for gripper controller #3023

Merged
merged 5 commits into from
Oct 21, 2024
Merged

fix parameter namespacing for gripper controller #3023

merged 5 commits into from
Oct 21, 2024

Conversation

mikeferguson
Copy link
Contributor

Description

Several parameters for the gripper controller interface are improperly namespaced and are not under their respective controller.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mikeferguson mikeferguson changed the title fix parameter name for parallel gripper mode fix parameter namespacing for gripper controller Oct 9, 2024
sjahr
sjahr reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind running pre-commit?

@mikeferguson
Copy link
Contributor Author

CI now passing after updating formatting

@mikeferguson mikeferguson added this pull request to the merge queue Oct 21, 2024
Merged via the queue into moveit:main with commit 1b8044a Oct 21, 2024
10 of 13 checks passed
@mikeferguson mikeferguson deleted the parallel_param_fix branch October 21, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeferguson @sjahr