Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin geometric_shapes repository to stable version #3132

Closed
wants to merge 5 commits into from
Closed

Pin geometric_shapes repository to stable version #3132

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c64ee59
Restore --with-new-pkgs arg in CI Dockerfile
sea-bass Nov 23, 2024
59f6e43
Pin version of geometric_shapes repo
sea-bass Nov 26, 2024
0f006ef
Update .docker/ci/Dockerfile
sea-bass Nov 26, 2024
4dcd678
Try reverting suspected change
sea-bass Nov 26, 2024
1e97f1f
Merge branch 'revert-geometric-shapes' of https://github.com/ros-plan…
sea-bass Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

ARG ROS_DISTRO=rolling
FROM ros:${ROS_DISTRO}-ros-base
LABEL maintainer Robert Haschke [email protected]

Check warning on line 6 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (rolling)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 6 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (jazzy)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

ENV TERM xterm

Check warning on line 8 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (rolling)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 8 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (jazzy)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Setup (temporary) ROS workspace
WORKDIR /root/ws_moveit
Expand All @@ -15,10 +15,10 @@

# Commands are combined in single RUN statement with "apt/lists" folder removal to reduce image size
# https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers
RUN \

Check failure on line 18 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / Lint Dockerfiles (ci) 

SC2086 info: Double quote to prevent globbing and word splitting.
# Update apt package list as previous containers clear the cache
apt-get -q update && \
apt-get -q -y upgrade && \
apt-get -q -y upgrade --with-new-pkgs && \
sea-bass marked this conversation as resolved.
Show resolved Hide resolved
#
# Install some base dependencies
apt-get -q install --no-install-recommends -y \
Expand Down
2 changes: 1 addition & 1 deletion moveit2.repos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ repositories:
geometric_shapes:
type: git
url: https://github.com/moveit/geometric_shapes.git
version: ros2
version: 4f65a38 # TODO: Fix the issues introduced in https://github.com/moveit/geometric_shapes/pull/239
moveit_msgs:
type: git
url: https://github.com/moveit/moveit_msgs.git
Expand Down
Loading