-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated tf2 imports from .h to .hpp (backport #3197) #3199
Conversation
* Update deprecated tf2 imports from .h to .hpp * make the imports conditional * Update all the files (cherry picked from commit 7390ebc) # Conflicts: # moveit_core/robot_state/test/test_aabb.cpp # moveit_kinematics/cached_ik_kinematics_plugin/include/moveit/cached_ik_kinematics_plugin/cached_ik_kinematics_plugin.hpp # moveit_planners/chomp/chomp_motion_planner/src/chomp_planner.cpp # moveit_planners/pilz_industrial_motion_planner/include/pilz_industrial_motion_planner/trajectory_functions.hpp # moveit_planners/pilz_industrial_motion_planner/src/trajectory_functions.cpp # moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_circ.cpp # moveit_ros/robot_interaction/src/interactive_marker_helpers.cpp # moveit_ros/robot_interaction/src/robot_interaction.cpp
Cherry-pick of 7390ebc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3199 +/- ##
==========================================
+ Coverage 51.37% 51.38% +0.01%
==========================================
Files 382 382
Lines 31890 31890
==========================================
+ Hits 16381 16383 +2
+ Misses 15509 15507 -2 ☔ View full report in Codecov by Sentry. |
Description
Surprise! More deprecations.
ros2/geometry2#720
This was also backported to Jazzy and Humble, so we will do the same here.
NOTE: Because these changes have not yet made it into Humble binaries, I have conditional includes in. But once Humble gets a sync, we can undo a lot of this and just go full
.hpp
.Checklist
This is an automatic backport of pull request #3197 done by [Mergify](https://mergify.com).