Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad logic in Servo twist speed scaling #3225

Closed
wants to merge 1 commit into from

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jan 10, 2025

Description

I mistakenly added some logic to the twist mode of MoveIt Servo in #3007 that did not need to be there.

When the speed commands are in real speed units, we should not touch their scaling value as documented!

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass
Copy link
Contributor Author

Wait no, I read the comment wrong. This is actually fine.

It says:

"Max linear velocity in m/s if using speed units or tracking a pose, else a scaling factor on the unitless commanded velocity. Used for Cartesian and pose tracking commands."

@sea-bass sea-bass closed this Jan 10, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.66%. Comparing base (cd26fc0) to head (dbdecfb).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   46.01%   45.66%   -0.34%     
==========================================
  Files         714      714              
  Lines       62317    62290      -27     
  Branches     7530     7527       -3     
==========================================
- Hits        28667    28438     -229     
- Misses      33484    33685     +201     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants