Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source builds of geometric_shapes and srdfdom #3233

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −11
Open

Remove source builds of geometric_shapes and srdfdom #3233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c140dc
Remove source builds of `geometric_shapes` and `srdfdom`
sea-bass Jan 12, 2025
f400c00
Don't remove the binaries in CI anymore
sea-bass Jan 12, 2025
eb4c4b9
Merge branch 'main' into remove-geometric-shapes-srdfdom-repos-file
sea-bass Jan 12, 2025
c25ff98
Ignore another lcov error?
sea-bass Jan 12, 2025
bb12ff7
Ignore lcov errors in sonar job also
sea-bass Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
moveit2.repos
$(f="moveit2_$(sed 's/-.*$//' <<< "${{ matrix.env.IMAGE }}").repos"; test -r $f && echo $f)
# Pull any updates to the upstream workspace (after restoring it from cache)
AFTER_SETUP_UPSTREAM_WORKSPACE: apt remove -y ros-$ROS_DISTRO-geometric-shapes; vcs pull $BASEDIR/upstream_ws/src
AFTER_SETUP_UPSTREAM_WORKSPACE: vcs pull $BASEDIR/upstream_ws/src
AFTER_SETUP_DOWNSTREAM_WORKSPACE: vcs pull $BASEDIR/downstream_ws/src
# Clear the ccache stats before and log the stats after the build
AFTER_SETUP_CCACHE: ccache --zero-stats --max-size=10.0G
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:
with:
docker: $DOCKER_IMAGE
workdir: ${{ env.BASEDIR }}/target_ws
lcov_capture_args: --ignore-errors=gcov,gcov,mismatch,mismatch,negative,negative
lcov_capture_args: --ignore-errors=gcov,gcov,mismatch,mismatch,negative,negative,source,source
ignore: '"*/target_ws/build/*" "*/target_ws/install/*" "*/test/*"'
- name: Upload codecov report
uses: codecov/codecov-action@v5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
with:
docker: $DOCKER_IMAGE
workdir: ${{ env.BASEDIR }}/target_ws
lcov_capture_args: --ignore-errors=gcov,gcov,mismatch,mismatch,negative,negative
lcov_capture_args: --ignore-errors=gcov,gcov,mismatch,mismatch,negative,negative,source,source
ignore: '"*/target_ws/build/*" "*/target_ws/install/*" "*/test/*"'
- name: Install ccache
run: sudo apt install ccache build-essential
Expand Down
8 changes: 0 additions & 8 deletions moveit2.repos
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
repositories:
# Keep moveit_* repos here because they are released with moveit
geometric_shapes:
type: git
url: https://github.com/moveit/geometric_shapes.git
version: ros2
moveit_msgs:
type: git
url: https://github.com/moveit/moveit_msgs.git
Expand All @@ -12,7 +8,3 @@ repositories:
type: git
url: https://github.com/moveit/moveit_resources.git
version: ros2
srdfdom:
type: git
url: https://github.com/moveit/srdfdom.git
version: ros2
Loading