Remove plugins from export set (backport #3227) #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Remove plugins from export set Signed-off-by: Paul Gesel <[email protected]> * move more plugins to different export set Signed-off-by: Paul Gesel <[email protected]> * run pre-commit Signed-off-by: Paul Gesel <[email protected]> * remove plugins from moveit_kinematics export Signed-off-by: Paul Gesel <[email protected]> * do not link base interface to plugin in kinematics Signed-off-by: Paul Gesel <[email protected]> --------- Signed-off-by: Paul Gesel <[email protected]> Co-authored-by: Sebastian Jahr <[email protected]> (cherry picked from commit b5eb4de)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## jazzy #3242 +/- ##
==========================================
+ Coverage 44.18% 44.18% +0.01%
==========================================
Files 698 698
Lines 61587 61587
Branches 7460 7460
==========================================
+ Hits 27203 27204 +1
Misses 34216 34216
+ Partials 168 167 -1 ☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugins that are intended to be loaded by classloader or pluginlib should not be in export sets that
ament_export_targetsis called on. This can cause plugins to fail to load.This is an automatic backport of pull request #3227 done by Mergify.