Reduce mutex scope in Servo thread (backport #3259) #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Fixes occasional main thread starvation caused by repeatedly creating a lock_guard in the servo loop. Fairness is improved by removing the thread sleep rate from the lock scope. (cherry picked from commit b91e529)
sea-bass
approved these changes
Jan 22, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## jazzy #3262 +/- ##
==========================================
- Coverage 44.13% 44.12% -0.00%
==========================================
Files 700 700
Lines 61663 61664 +1
Branches 7471 7471
==========================================
- Hits 27206 27201 -5
- Misses 34289 34295 +6
Partials 168 168 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes occasional main thread starvation caused by repeatedly creating a lock_guard in the servo loop. One side effect would be that the pause_servo service would not respond. Fairness is improved by removing the thread sleep rate from the lock scope.
This is an automatic backport of pull request #3259 done by [Mergify](https://mergify.com).