Add rudimentary stl support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really cool, ill test it shortly 🎉
…On Thu, 28 Nov, 2024, 9:16 am Sebastian Jahr, ***@***.***> wrote:
@sjahr <https://github.com/sjahr> requested your review on: #64
<#64> Add rudimentary stl
support.
—
Reply to this email directly, view it on GitHub
<#64 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNFZJBTNCI3TKQ3T72SELT2C3NN5AVCNFSM6AAAAABSUUT4M6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGQ3DENBZGU2DSMI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Thanks @sea-bass! Ready for round 2. |
sea-bass
approved these changes
Nov 29, 2024
sjahr
commented
Nov 29, 2024
sjahr
commented
Nov 29, 2024
Co-authored-by: Sebastian Castro <[email protected]>
Comment on lines
+243
to
+260
| std::string result = input; | ||
| const std::string lower_case_stl = ".stl"; | ||
| const std::string upper_case_stl = ".STL"; | ||
| const std::string replacement = ".obj"; | ||
|
|
||
| size_t pos = 0; | ||
| while ((pos = result.find(lower_case_stl, pos)) != std::string::npos) | ||
| { | ||
| result.replace(pos, lower_case_stl.length(), replacement); | ||
| pos += replacement.length(); // Move past the replacement to avoid infinite loop | ||
| } | ||
|
|
||
| pos = 0; | ||
| while ((pos = result.find(upper_case_stl, pos)) != std::string::npos) | ||
| { | ||
| result.replace(pos, upper_case_stl.length(), replacement); | ||
| pos += replacement.length(); // Move past the replacement to avoid infinite loop | ||
| } |
There was a problem hiding this comment.
As i understood, you're trying to change file extenstions only. By asssuming it is used c++17 standard, why didn't you consider to use filesystem library's replace extenstion for this stuff?
| @@ -1,4 +1,6 @@ | |||
| #include <cmath> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
Is this header really necessary?
| @@ -13,8 +13,8 @@ repositories: | |||
| version: main | |||
| moveit_resources: | |||
| type: git | |||
| url: https://github.com/moveit/moveit_resources | |||
| version: ros2 | |||
| url: https://github.com/sjahr/moveit_resources | |||
There was a problem hiding this comment.
I am worried about the fact that dockerfile doesnt use this repos file.
Comment on lines
+244
to
+246
| const std::string lower_case_stl = ".stl"; | ||
| const std::string upper_case_stl = ".STL"; | ||
| const std::string replacement = ".obj"; |
There was a problem hiding this comment.
Why didn't we think of to use constexpr here? Just take it as a question bc i haven't use constexpr before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wouldn't call it .stl support but at least everybody should be able to use moveit configs other than the panda with this 😅