Bug 1847999 - Switch to using non-deprecated constructor for Migratio…

…nTestHelper.
mozilla-mobile · Feb 12, 2024 · 62662cd · 62662cd
1 parent 0daebd8
commit 62662cd
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 24 deletions.
diff --git a/.../src/androidTest/java/mozilla/components/feature/downloads/OnDeviceDownloadStorageTest.kt b/.../src/androidTest/java/mozilla/components/feature/downloads/OnDeviceDownloadStorageTest.kt
@@ -7,7 +7,6 @@ package mozilla.components.feature.downloads
 import android.content.Context
 import androidx.room.Room
 import androidx.room.testing.MigrationTestHelper
-import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.platform.app.InstrumentationRegistry
 import kotlinx.coroutines.ExperimentalCoroutinesApi
@@ -32,11 +31,9 @@ class OnDeviceDownloadStorageTest {
     private lateinit var database: DownloadsDatabase
 
     @get:Rule
-    @Suppress("DEPRECATION")
     val helper: MigrationTestHelper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        DownloadsDatabase::class.java.canonicalName,
-        FrameworkSQLiteOpenHelperFactory(),
+        DownloadsDatabase::class.java,
     )
 
     @Before

diff --git a/...ogins/src/androidTest/java/mozilla/components/feature/logins/LoginExceptionStorageTest.kt b/...ogins/src/androidTest/java/mozilla/components/feature/logins/LoginExceptionStorageTest.kt
@@ -8,7 +8,6 @@ import android.content.Context
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
 import androidx.room.Room
 import androidx.room.testing.MigrationTestHelper
-import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.platform.app.InstrumentationRegistry
 import kotlinx.coroutines.flow.first
@@ -37,11 +36,9 @@ class LoginExceptionStorageTest {
     var instantTaskExecutorRule = InstantTaskExecutorRule()
 
     @get:Rule
-    @Suppress("DEPRECATION")
     val helper: MigrationTestHelper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        LoginExceptionStorage::class.java.canonicalName,
-        FrameworkSQLiteOpenHelperFactory(),
+        LoginExceptionDatabase::class.java,
     )
 
     @Before

diff --git a/...a/src/androidTest/java/mozilla/components/feature/pwa/db/ManifestDatabaseMigrationTest.kt b/...a/src/androidTest/java/mozilla/components/feature/pwa/db/ManifestDatabaseMigrationTest.kt
@@ -6,7 +6,6 @@ package mozilla.components.feature.pwa.db
 
 import androidx.core.database.getStringOrNull
 import androidx.room.testing.MigrationTestHelper
-import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
 import androidx.test.platform.app.InstrumentationRegistry
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNull
@@ -20,11 +19,9 @@ class ManifestDatabaseMigrationTest {
 
     @Rule
     @JvmField
-    @Suppress("DEPRECATION")
     val helper: MigrationTestHelper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        ManifestDatabase::class.java.canonicalName,
-        FrameworkSQLiteOpenHelperFactory(),
+        ManifestDatabase::class.java,
     )
 
     @Test

diff --git a/.../java/mozilla/components/feature/sitepermissions/db/OnDeviceSitePermissionsStorageTest.kt b/.../java/mozilla/components/feature/sitepermissions/db/OnDeviceSitePermissionsStorageTest.kt
@@ -8,7 +8,6 @@ import android.content.Context
 import androidx.core.net.toUri
 import androidx.room.Room
 import androidx.room.testing.MigrationTestHelper
-import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.platform.app.InstrumentationRegistry
 import kotlinx.coroutines.test.runTest
@@ -34,11 +33,9 @@ class OnDeviceSitePermissionsStorageTest {
     private lateinit var database: SitePermissionsDatabase
 
     @get:Rule
-    @Suppress("DEPRECATION")
     val helper: MigrationTestHelper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        SitePermissionsDatabase::class.java.canonicalName,
-        FrameworkSQLiteOpenHelperFactory(),
+        SitePermissionsDatabase::class.java,
     )
 
     @Before

diff --git a/...c/androidTest/java/mozilla/components/feature/top/sites/OnDevicePinnedSitesStorageTest.kt b/...c/androidTest/java/mozilla/components/feature/top/sites/OnDevicePinnedSitesStorageTest.kt
@@ -8,7 +8,6 @@ import android.content.Context
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
 import androidx.room.Room
 import androidx.room.testing.MigrationTestHelper
-import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.platform.app.InstrumentationRegistry
 import kotlinx.coroutines.ExperimentalCoroutinesApi
@@ -38,11 +37,9 @@ class OnDevicePinnedSitesStorageTest {
     var instantTaskExecutorRule = InstantTaskExecutorRule()
 
     @get:Rule
-    @Suppress("DEPRECATION")
     val helper: MigrationTestHelper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        TopSiteDatabase::class.java.canonicalName,
-        FrameworkSQLiteOpenHelperFactory(),
+        TopSiteDatabase::class.java,
     )
 
     @Before

diff --git a/...st/java/mozilla/components/service/pocket/stories/db/PocketRecommendationsDatabaseTest.kt b/...st/java/mozilla/components/service/pocket/stories/db/PocketRecommendationsDatabaseTest.kt
@@ -8,7 +8,6 @@ import android.content.Context
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
 import androidx.room.Room
 import androidx.room.testing.MigrationTestHelper
-import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.platform.app.InstrumentationRegistry
 import kotlinx.coroutines.runBlocking
@@ -31,11 +30,9 @@ class PocketRecommendationsDatabaseTest {
     private lateinit var database: PocketRecommendationsDatabase
 
     @get:Rule
-    @Suppress("DEPRECATION")
     val helper: MigrationTestHelper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        PocketRecommendationsDatabase::class.java.canonicalName,
-        FrameworkSQLiteOpenHelperFactory(),
+        PocketRecommendationsDatabase::class.java,
     )
 
     @get:Rule