Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1875106 - Add shopping api to send placement attribution event #5246

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

calumozilla
Copy link
Contributor

@calumozilla calumozilla commented Jan 22, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1875106

@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jan 22, 2024
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple pedantic nits, but this looks good to me!

@github-actions github-actions bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 25, 2024
@calumozilla calumozilla added the 🛬 needs landing PRs that are ready to land label Jan 26, 2024
@mergify mergify bot merged commit 3a651ad into mozilla-mobile:main Jan 26, 2024
109 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants