Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1876481 - Updated HomeActivity variables & funcs with the necessary visibility modifiers to enforce constraints. #5291

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Bug 1876481 - Updated HomeActivity variables & funcs with the necessary visibility modifiers to enforce constraints. #5291

merged 2 commits into from
Jan 25, 2024

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Jan 25, 2024 •
edited by github-actions bot
Loading

No changes required for ExternalAppBrowserActivity.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1876481

@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jan 25, 2024
@t-p-white t-p-white requested a review from a team January 25, 2024 11:03
@t-p-white t-p-white force-pushed the 1876481 branch 2 times, most recently from e77c747 to 5fb422c Compare January 25, 2024 15:37
@t-p-white
Bug 1876481 - Updated HomeActivity variables & funcs with the neces…
08556f4 
…sary visibility modifiers to enforce constraints.
@github-actions github-actions bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 25, 2024
@t-p-white t-p-white added the 🛬 needs landing PRs that are ready to land label Jan 25, 2024
@mergify mergify bot merged commit 2562a5f into mozilla-mobile:main Jan 25, 2024
23 checks passed
@t-p-white t-p-white deleted the 1876481 branch January 31, 2024 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MozillaNoah MozillaNoah MozillaNoah approved these changes

Assignees

@MozillaNoah MozillaNoah

Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-p-white @MozillaNoah