Bug 1876610 - Minor Translations UI Adjustments #5305
Conversation
| websiteUrl = "expedia.ca", | ||
| ), | ||
| ) | ||
| add( | ||
| NeverTranslateSiteListItemPreference( | ||
| websiteUrl = "wikipedia.com", | ||
| websiteUrl = "mozilla.org", |
There was a problem hiding this comment.
Correct, wanting to open up for L10N review and thought we shouldn't have unaffiliated references.
github-actions
bot
added
approved
|
@gabrielluong Sorry, had a quick change right after approval, can you take a look again? I think I needed a new string for the content description. (Had a little bit of back and forth with myself, but I think where we will need a different one for when it opens, we should maybe have the toolbar string be a different reference than the browser string.) What do you think? |
| <!-- Content description for the translate page toolbar button that opens the translations dialog when no translation has occurred. --> | ||
| <string name="browser_toolbar_translate">Translate page</string> |
There was a problem hiding this comment.
Let's move this below L236 since we have actually have a Browser Toolbar section and you probably want to add a new line to space out the sections.
There was a problem hiding this comment.
Thanks, yeah totally didn't see <!-- Locale Settings Fragment --> stuck between the browser toolbar section and what I added. 🔎
Moved it up and made the spacing between sections more clear.
This patch completes a few minor translations UI adjustments. Including updating mock data on the "never translate these sites" page and the "language settings" page. Additionally, adds a content description on the toolbar for the translation icon.
This patch completes a few minor translations UI adjustments. Including updating mock data on the "never translate these sites" page and the "language settings" page.
Additionally, adds a content description on the toolbar for the translation icon.
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1876610