Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1864760 - Added actions to Toolbar and MenuButton to hide and show the menu button. #5306

Conversation

HarrisonOg
Copy link
Contributor

@HarrisonOg HarrisonOg commented Jan 25, 2024

Moving the A-C changes from the dev branch to separate PR that can land before dev branch.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1864760

@gabrielluong gabrielluong added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 25, 2024
@HarrisonOg HarrisonOg force-pushed the toolbarRedesign/1864760-hide-show-menu-action branch 6 times, most recently from bf05e86 to 017fbe1 Compare January 26, 2024 20:54
@HarrisonOg HarrisonOg added the 🛬 needs landing PRs that are ready to land label Jan 29, 2024
@dsmithpadilla
Copy link
Contributor

@HarrisonOg ci on lint-ktlint-android-components (Exceeded max line length (120) that prevents this from landing

@HarrisonOg HarrisonOg force-pushed the toolbarRedesign/1864760-hide-show-menu-action branch from a7928bf to deeb8e0 Compare January 29, 2024 19:24
@HarrisonOg HarrisonOg force-pushed the toolbarRedesign/1864760-hide-show-menu-action branch from deeb8e0 to b9399fa Compare January 29, 2024 20:13
@mergify mergify bot merged commit 9045188 into mozilla-mobile:main Jan 29, 2024
84 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants