Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1877847 - Remove Suggest error reporting #5390

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Jan 31, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1877847

@bendk bendk requested a review from linabutler January 31, 2024 22:34
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 31, 2024
@bendk
Copy link
Contributor Author

bendk commented Jan 31, 2024

This is a companion to mozilla/application-services#6088. We should probably merge that one first, but it's not a hard dependency. If this one gets merged first, then we'll lose Sentry data in the meantime.

Copy link
Contributor

@linabutler linabutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@linabutler linabutler added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 1, 2024
@bendk
Copy link
Contributor Author

bendk commented Feb 2, 2024

The logs of test-apk-fenix-debug look like a transient error to me and the test is passing when I run it locally, so I'm going to go ahead and land this one.

@bendk bendk added the 🛬 needs landing PRs that are ready to land label Feb 2, 2024
@mergify mergify bot merged commit 4dd7c2d into mozilla-mobile:main Feb 2, 2024
36 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants