Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Revert "Bug 1875294 - Record breadbcrumbs before crashing with Unsats… #5414

Merged

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Feb 1, 2024

…isfiedLinkError"

This reverts commit 6fb061c.

These didn't work out in practice. The file lists were always empty, I think it might be a difference in permissions for release builds vs the debug builds that I was testing with.

The package installer name was useful, but I realized there's Sentry tag for that which is even more useful.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1875294

@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Feb 1, 2024
…isfiedLinkError"

This reverts commit 6fb061c.

These didn't work out in practice.  The file lists were always empty, I
think it might be a difference in permissions for release builds vs the
debug builds that I was testing with.

The package installer name was useful, but I realized there's Sentry tag for that which is even more useful.
@bendk bendk force-pushed the revert-unsatisfied-link-error-breadcrumbs branch from 2454d20 to 6cbde14 Compare February 9, 2024 20:42
@rocketsroger rocketsroger added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 12, 2024
@bendk bendk added the 🛬 needs landing PRs that are ready to land label Feb 12, 2024
@mergify mergify bot merged commit 5c0e0ca into mozilla-mobile:main Feb 12, 2024
23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants