Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data #5461

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Feb 5, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1876806

@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 6, 2024
@github-actions github-actions bot added the approved PR that has been approved label Feb 6, 2024
@mergify mergify bot merged commit a1f24ff into mozilla-mobile:main Feb 6, 2024
47 of 48 checks passed
@Amejia481
Copy link
Contributor Author

@Mergifyio backport releases_v123

Copy link
Contributor

mergify bot commented Feb 8, 2024

backport releases_v123

✅ Backports have been created

pascalchevrel pushed a commit that referenced this pull request Feb 8, 2024
…leting browsing data (backport #5461) (#5525)

(cherry picked from commit a1f24ff)

Co-authored-by: Arturo Mejia <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants