This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1876823 - Add action to fetch list of sites that should not be tr… #5463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumozilla
force-pushed
the
bug1876823
branch
from
359308f to
e887898
Compare
ohall-m
approved these changes
Feb 5, 2024
...e/src/main/java/mozilla/components/browser/state/engine/middleware/TranslationsMiddleware.kt
Outdated
Show resolved
Hide resolved
...ser/state/src/main/java/mozilla/components/browser/state/reducer/TranslationsStateReducer.kt
Outdated
Show resolved
Hide resolved
| @@ -203,6 +203,24 @@ class TranslationsActionTest { | |||
| assertEquals(supportedLanguages, tabState().translationsState.supportedLanguages) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `WHEN a SetNeverTranslateSitesAction is dispatched AND successful THEN update neverTranslateSites`() { | |||
There was a problem hiding this comment.
I think I figured out what was going on with the TranslationsMiddlewareTest.kt pattern over in #5389. That test now seems to be verifying as expected and I think could be used as a pattern for an additional test on this patch too.
There was a problem hiding this comment.
Great! I added the setup and tested it out, and will rebase when you have that merged in.
There was a problem hiding this comment.
Awesome, thanks and thanks for the review! #5389 just merged!
...ponents/browser/state/src/main/java/mozilla/components/browser/state/action/BrowserAction.kt
Show resolved
Hide resolved
...e/src/main/java/mozilla/components/browser/state/engine/middleware/TranslationsMiddleware.kt
Outdated
Show resolved
Hide resolved
ohall-m
reviewed
Feb 5, 2024
...ents/browser/state/src/main/java/mozilla/components/browser/state/state/TranslationsState.kt
Outdated
Show resolved
Hide resolved
calumozilla
force-pushed
the
bug1876823
branch
from
e887898 to
1a2a6b0
Compare
github-actions
bot
added
approved
calumozilla
force-pushed
the
bug1876823
branch
from
1a2a6b0 to
79133e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anslated
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1876823