This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1877203 - Update Translations Page Settings #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🕵️♀️ needs review
|
This pull request has conflicts when rebasing. Could you fix it @ohall-m? 🙏 |
ohall-m
added
work in progress
ohall-m
changed the title
github-actions
bot
added
🕵️♀️ needs review
ohall-m
added
work in progress
ohall-m
changed the title
github-actions
bot
added
🕵️♀️ needs review
4 tasks
ohall-m
added
work in progress
github-actions
bot
added
🕵️♀️ needs review
ohall-m
added
🕵️♀️ needs review
calumozilla
reviewed
Feb 13, 2024
| onError = errorCallback.capture(), | ||
| ), | ||
| ) | ||
| .thenAnswer { errorCallback.value.invoke(Throwable()) } |
There was a problem hiding this comment.
nit: remove the indent or move it up one line for better readability?
calumozilla
approved these changes
Feb 13, 2024
|
This pull request has conflicts when rebasing. Could you fix it @ohall-m? 🙏 |
The goal of this bug is to have a way to update page settings.
It adds:
* A new action, `UpdatePageSettingAction`
* This action has four options:
* `UPDATE_ALWAYS_OFFER_POPUP`
* `UPDATE_ALWAYS_TRANSLATE_LANGUAGE`
* `UPDATE_NEVER_TRANSLATE_LANGUAGE`
* `UPDATE_NEVER_TRANSLATE_SITE`
* Each operation eagerly sets the new setting on the browser store, then
sends the request to the engine. If setting on the engine fails, then
they will re-request the page settings in order to remain in-sync.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this bug is to have a way to update page settings.
It adds:
UpdatePageSettingActionUPDATE_ALWAYS_OFFER_POPUPUPDATE_ALWAYS_TRANSLATE_LANGUAGEUPDATE_NEVER_TRANSLATE_LANGUAGEUPDATE_NEVER_TRANSLATE_SITEsends the request to the engine. If setting on the engine fails, then
they will re-request the page settings in order to remain in-sync.
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1877203