Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1878868 - Create TestSetup helper: Test classes A-C (fix for legacy APIs) #5517

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Feb 8, 2024

Added the API level condition and re-ran the tests on the legacy API devices: matrix link.
Everything passed.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1878868

@sv-ohorvath sv-ohorvath self-assigned this Feb 8, 2024
@sv-ohorvath sv-ohorvath added the work in progress Not ready to land yet. Work in progress (WIP). label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

@sv-ohorvath sv-ohorvath marked this pull request as ready for review February 8, 2024 15:58
@sv-ohorvath sv-ohorvath requested review from AaronMT and jjSDET February 8, 2024 15:58
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Feb 8, 2024
Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment would be great

@github-actions github-actions bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 9, 2024
@sv-ohorvath sv-ohorvath added the 🛬 needs landing PRs that are ready to land label Feb 9, 2024
@mergify mergify bot merged commit 9c4e2ef into mozilla-mobile:main Feb 9, 2024
23 checks passed
@sv-ohorvath sv-ohorvath deleted the oana_testSetupHelper branch February 28, 2024 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants