This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
Bug 1878868 - Create TestSetup helper: Test classes A-C (fix for legacy APIs) #5517
Merged
+150
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sv-ohorvath
added
the
work in progress
Not ready to land yet. Work in progress (WIP).
label
Feb 8, 2024
🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs The comment message should look like:
|
sv-ohorvath
force-pushed
the
oana_testSetupHelper
branch
from
February 8, 2024 14:04
1a4f3a0
to
1b57d41
Compare
🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs The comment message should look like:
|
sv-ohorvath
force-pushed
the
oana_testSetupHelper
branch
from
February 8, 2024 14:36
1b57d41
to
7795087
Compare
🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs The comment message should look like:
|
1 similar comment
🚧 Commit message is using the wrong format: Fix clearDownloadsFolder method for legacy APIs The comment message should look like:
|
sv-ohorvath
force-pushed
the
oana_testSetupHelper
branch
from
February 8, 2024 15:57
a038852
to
39538c2
Compare
github-actions
bot
added
🕵️♀️ needs review
PRs that need to be reviewed
and removed
work in progress
Not ready to land yet. Work in progress (WIP).
labels
Feb 8, 2024
sv-ohorvath
force-pushed
the
oana_testSetupHelper
branch
from
February 8, 2024 16:23
39538c2
to
e4907c8
Compare
AaronMT
reviewed
Feb 8, 2024
fenix/app/src/androidTest/java/org/mozilla/fenix/helpers/AppAndSystemHelper.kt
Show resolved
Hide resolved
AaronMT
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a comment would be great
sv-ohorvath
force-pushed
the
oana_testSetupHelper
branch
from
February 9, 2024 08:54
e4907c8
to
c183a6d
Compare
github-actions
bot
added
approved
PR that has been approved
and removed
🕵️♀️ needs review
PRs that need to be reviewed
labels
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the API level condition and re-ran the tests on the legacy API devices: matrix link.
Everything passed.
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-apk-{fenix,focus,klar}-debug
task you're interested in.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1878868