Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1816066 - Fix verifyMultipleLoginsSelectionsTest UI test #5532

Merged

Conversation

AndiAJ
Copy link
Contributor

@AndiAJ AndiAJ commented Feb 9, 2024

Summary:

  • The UI test was flaky due to the fact that after filling out the second time the loging credentials the click on the submit button wasn't performed properly in some cases
  • Instead of clicking the "Submit" button it looks like the password text box got clicked again selecting the previously added string, launching the text selection toolbar
image
  • I think that the click was poorly performed because of sync problems, namely the credential filing actions were performed way to fast causing inconsistencies
  • To overcome this problem, I've created the waitForAppWindowToBeUpdated function which will wait for waitingTimeVeryShort(1 sec) for the app window do be updated after each login credential filing action.

The UI test successfully passed 200x on Firebase ✅

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1816066

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Feb 9, 2024
@AndiAJ AndiAJ force-pushed the verifyMultipleLoginsSelectionsTest branch 2 times, most recently from 6aaa6bd to e96d996 Compare February 9, 2024 11:35
@AndiAJ AndiAJ changed the title Status check verifyMultipleLoginsSelectionsTest UI test Bug 1816066 - Fix verifyMultipleLoginsSelectionsTest UI test Feb 9, 2024
@AndiAJ AndiAJ force-pushed the verifyMultipleLoginsSelectionsTest branch from e96d996 to 481e793 Compare February 9, 2024 12:58
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Feb 9, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Feb 9, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Feb 9, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Feb 9, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Feb 9, 2024
@mozilla-mobile mozilla-mobile deleted a comment from github-actions bot Feb 9, 2024
@AndiAJ AndiAJ marked this pull request as ready for review February 9, 2024 13:36
@AndiAJ AndiAJ self-assigned this Feb 9, 2024
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Feb 9, 2024
@AndiAJ AndiAJ requested review from AaronMT, sv-ohorvath and jjSDET and removed request for AaronMT February 9, 2024 13:36
@AndiAJ AndiAJ added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 12, 2024
@github-actions github-actions bot added the approved PR that has been approved label Feb 12, 2024
@mergify mergify bot merged commit cd5b549 into mozilla-mobile:main Feb 12, 2024
23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants