Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1879525 - Create TestSetup helper: Compose Test classes #5536

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Feb 9, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1879525

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Feb 9, 2024
@sv-ohorvath sv-ohorvath force-pushed the composeTestsSetupHelper branch 4 times, most recently from 6a8716c to 243a46d Compare February 12, 2024 13:19
@sv-ohorvath sv-ohorvath marked this pull request as ready for review February 12, 2024 13:40
@sv-ohorvath sv-ohorvath self-assigned this Feb 12, 2024
@sv-ohorvath sv-ohorvath requested review from jjSDET and AndiAJ and removed request for jjSDET February 12, 2024 13:40
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Feb 12, 2024
@sv-ohorvath sv-ohorvath requested a review from jjSDET February 12, 2024 13:40
@sv-ohorvath sv-ohorvath force-pushed the composeTestsSetupHelper branch from 6bf5535 to aad921d Compare February 13, 2024 13:41
Copy link
Contributor

mergify bot commented Feb 13, 2024

This pull request has conflicts when rebasing. Could you fix it @sv-ohorvath? 🙏

@sv-ohorvath sv-ohorvath force-pushed the composeTestsSetupHelper branch from aad921d to 9874951 Compare February 16, 2024 11:39
@sv-ohorvath sv-ohorvath force-pushed the composeTestsSetupHelper branch 2 times, most recently from 6dd4284 to a6e1a01 Compare February 20, 2024 14:10
Copy link
Contributor

@jjSDET jjSDET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sv-ohorvath sv-ohorvath force-pushed the composeTestsSetupHelper branch from a6e1a01 to e943f22 Compare February 26, 2024 09:33
@github-actions github-actions bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 26, 2024
@sv-ohorvath sv-ohorvath added 🛬 needs landing PRs that are ready to land and removed approved PR that has been approved labels Feb 26, 2024
@github-actions github-actions bot added the approved PR that has been approved label Feb 26, 2024
@mergify mergify bot merged commit 1898c06 into mozilla-mobile:main Feb 26, 2024
23 checks passed
@sv-ohorvath sv-ohorvath deleted the composeTestsSetupHelper branch February 28, 2024 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants