Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1879583 - Change the default for pull-to-refresh to enabled #5539

Merged

Conversation

titooan
Copy link
Contributor

@titooan titooan commented Feb 9, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1879583

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Feb 9, 2024
@titooan titooan marked this pull request as ready for review February 9, 2024 17:04
@titooan titooan requested a review from jonalmeida February 9, 2024 17:04
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Feb 9, 2024
Copy link
Collaborator

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👇 🔁

Land it!

@titooan titooan added 🛬 needs landing PRs that are ready to land approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 9, 2024
@titooan
Copy link
Contributor Author

titooan commented Feb 9, 2024

@Mergifyio backport releases_v123

Copy link
Contributor

mergify bot commented Feb 9, 2024

backport releases_v123

✅ Backports have been created

@mergify mergify bot merged commit 0733fc0 into mozilla-mobile:main Feb 9, 2024
23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants