Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1880328 - Fix state checking issues #5603

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Feb 14, 2024

  • Send EnsureCapabilitiesAuthError to the state machine checker, which was created exactly for this case.
  • Handle the CancelAuth event rather than letting it fall to the else case and ignore it.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1880328

- Send EnsureCapabilitiesAuthError to the state machine checker, which was
  created exactly for this case.
- Handle the CancelAuth event rather than letting it fall to the `else`
  case and ignore it.
@bendk bendk requested a review from linabutler February 14, 2024 17:09
@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Feb 14, 2024
@bendk bendk added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Feb 14, 2024
@github-actions github-actions bot added the approved PR that has been approved label Feb 14, 2024
@mergify mergify bot merged commit e8ae477 into mozilla-mobile:main Feb 14, 2024
41 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants