Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1880328 - Fix state checking issues #5603

Merged
merged 2 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class FxaDeviceConstellation(
AppServicesStateMachineChecker.handleInternalEvent(FxaStateCheckerEvent.CallError)
throw e
} catch (e: FxaUnauthorizedException) {
AppServicesStateMachineChecker.handleInternalEvent(FxaStateCheckerEvent.CallError)
AppServicesStateMachineChecker.handleInternalEvent(FxaStateCheckerEvent.EnsureCapabilitiesAuthError)
// Unless we've added a new capability, in practice 'ensureCapabilities' isn't
// actually expected to do any work: everything should have been done by initializeDevice.
// So if it did, and failed, let's report this so that we're aware of this!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ object AppServicesStateMachineChecker {
Event.Account.Logout -> FxaEvent.Disconnect
// This is the one ProgressEvent that's considered a "public event" in app-services
is Event.Progress.AuthData -> FxaEvent.CompleteOAuthFlow(event.authData.code, event.authData.state)
is Event.Progress.CancelAuth -> FxaEvent.CancelOAuthFlow
else -> return
}
rustChecker.handlePublicEvent(convertedEvent)
Expand Down
Loading