Bug 1854131 - Three-dot main menu falls off screen, disappears in landscape mode

[AdrianaMaries]

Bug 1854131 - Three-dot main menu falls off screen, disappears in landscape mode

The popup doesn't fits up or fits down, because both availableHeightToTop and availableHeightToBottom are smaller than containerHeight. Because of this the popup is not displayed. As the popup is scrollable we should display it where the height is bigger (top or bottom).

https://bugzilla.mozilla.org/show_bug.cgi?id=1854131

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

1. Click on Checks at the top of the PR page.
2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
4. Click on View task in Taskcluster in the new DETAILS section.
5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1854131

[t-p-white]

Great job @AdrianaMaries, this fix looks good to me. Can we add a unit test also please to assert this new condition? 🙏

[AdrianaMaries]

@t-p-white Added a unit test to assert the new condition.

[t-p-white]

Thanks @AdrianaMaries! Sorry for the delay, should we also have a test for availableHeightToBottom is less than availableHeightToTop?

[AdrianaMaries]

@t-p-white Please see my changes. Thanks.

[t-p-white]

should this be:

Suggested change

	fun `GIVEN inferMenuPositioningData WHEN availableHeightToTop is bigger than availableHeightToBottom THEN it returns a new MenuPositioningData populated with all data needed to show a PopupWindow that fits down`() {
	fun `GIVEN inferMenuPositioningData WHEN availableHeightToTop is bigger than availableHeightToBottom THEN it returns a new MenuPositioningData populated with all data needed to show a PopupWindow that fits up`() {

?

[AdrianaMaries]

@t-p-white Yes. Updated.

[t-p-white]

Thanks @AdrianaMaries! Just a minor comment from me

[AdrianaMaries]

@t-p-white Please see my changes.

[t-p-white]

Thanks @AdrianaMaries! lgtm 😎 With the move to the monorepo this PR will be closed and your changes will be included in https://phabricator.services.mozilla.com/D205207