Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Request Context button Contact person mention #3051

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix Request Context button Contact person mention #3051

merged 3 commits into from
Dec 18, 2023

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Dec 15, 2023 •
edited
Loading

Fix #3050.

Factoring out the TeamComments component broke the ability to insert the contact person via Request Context button.

@mathjazz mathjazz requested a review from eemeli December 15, 2023 09:16
eemeli
eemeli approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack is fine, but should make it clear that it's required due to #2300.

translate/src/modules/entitydetails/components/Helpers.tsx Show resolved Hide resolved
translate/src/modules/entitydetails/components/Helpers.tsx Show resolved Hide resolved
mathjazz and others added 2 commits December 18, 2023 09:37
@mathjazz @eemeli
Add comment
6e0c939 
Co-authored-by: Eemeli Aro <[email protected]>
@mathjazz @eemeli
Add comment
16dc282 
Co-authored-by: Eemeli Aro <[email protected]>
@mathjazz mathjazz merged commit 8b1542d into mozilla:main Dec 18, 2023
4 checks passed
@mathjazz mathjazz deleted the 3050-request-report-fix branch December 18, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST CONTEXT or REPORT ISSUE doesn't CC project manager
2 participants
@mathjazz @eemeli