Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken translate view when filters result in no matches #3054

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix broken translate view when filters result in no matches #3054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions translate/src/modules/entitieslist/components/EntitiesList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ export function EntitiesList(): React.ReactElement<'div'> {
const mounted = useRef(false);
const list = useRef<HTMLDivElement>(null);

const selectedEntitiesCount = batchactions.entities.length;
const windowWidth = useWindowWidth();
const entitiesList = useContext(EntitiesListContext);
const quitBatchActions = useCallback(() => dispatch(resetSelection()), []);
const showBatchActions = useCallback(() => entitiesList.show(false), []);

useEffect(() => {
const handleShortcuts = (ev: KeyboardEvent) => {
// On Ctrl + Shift + A, select all entities for batch editing.
Expand Down Expand Up @@ -272,12 +278,6 @@ export function EntitiesList(): React.ReactElement<'div'> {
);
}

const selectedEntitiesCount = batchactions.entities.length;
const windowWidth = useWindowWidth();
const entitiesList = useContext(EntitiesListContext);
const quitBatchActions = useCallback(() => dispatch(resetSelection()), []);
const showBatchActions = useCallback(() => entitiesList.show(false), []);

return (
<div className='entities unselectable' ref={list}>
<ul>
Expand Down