Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create email consent page #3231

Merged
merged 9 commits into from
May 20, 2024
Merged

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented May 15, 2024

Fix #3219: Adds Email consent screen as per the spec for existing and new users.

The patch is deployed to stage:
https://mozilla-pontoon-staging.herokuapp.com/

@mathjazz mathjazz force-pushed the 3219-email-consent branch from 441bd52 to c898b53 Compare May 15, 2024 19:24
@mathjazz mathjazz force-pushed the 3219-email-consent branch from c898b53 to 6634366 Compare May 15, 2024 19:49
@mathjazz
Copy link
Collaborator Author

@bcolsson Could you please test this on stage and let me know if there are any changes needed to the functionality?

After you dismiss the email consent screen, you can enable it again by clearing the "Email consent dismissed at" Time and Date fields for your Pontoon user.

@mathjazz mathjazz requested a review from bcolsson May 15, 2024 20:33
Copy link
Collaborator

@bcolsson bcolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'm curious if we should make the header for the email consents configurable as well, but I'll leave the decision up to you.

pontoon/messaging/templates/messaging/email_consent.html Outdated Show resolved Hide resolved
@mathjazz mathjazz force-pushed the 3219-email-consent branch from 0c0b841 to 99a9b2d Compare May 16, 2024 08:34
@mathjazz mathjazz requested a review from eemeli May 16, 2024 08:44
@mathjazz
Copy link
Collaborator Author

Sorry, added missing Middleware tests:
e293e96

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the line comments, I'm a bit concerned that the interstitial page only explains what happens if a user consents to emails, and not what happens if they choose "No, thanks". Could text about that be included?

I would expect it to say something like "If you opt out, you'll still be able to enable emails later from the settings page."

docker/config/server.env.template Show resolved Hide resolved
docs/admin/deployment.rst Outdated Show resolved Hide resolved
pontoon/messaging/templates/messaging/email_consent.html Outdated Show resolved Hide resolved
pontoon/base/middleware.py Show resolved Hide resolved
@mathjazz
Copy link
Collaborator Author

mathjazz commented May 17, 2024

Besides the line comments, I'm a bit concerned that the interstitial page only explains what happens if a user consents to emails, and not what happens if they choose "No, thanks". Could text about that be included?

I would expect it to say something like "If you opt out, you'll still be able to enable emails later from the settings page."

Texts are part of the spec and were created together with legal, so I'll let @bcolsson comment on that.

Also for this:

The "just" is unnecessary here.

@bcolsson
Copy link
Collaborator

We could add it and ask legal to review the final page. I'm not sure how we'd fit something specifically pointing out what happens if they choose no with the current design, but we could add something below the privacy notice like:

You can change your email communication preferences at any time from your <a href="">settings</a> page.

@mathjazz
Copy link
Collaborator Author

We could add it and ask legal to review the final page. I'm not sure how we'd fit something specifically pointing out what happens if they choose no with the current design, but we could add something below the privacy notice like:

You can change your email communication preferences at any time from your <a href="">settings</a> page.

The sooner we ship this feature, the sooner we can start sending emails to the community. Another round of review with legal and no clear idea for the design is likely to delay this process. Let's go ahead with the patch and, if needed, file a bug for potential copy improvements.

@eemeli Do you have further requests for improvements?

@mathjazz mathjazz merged commit 7f78be7 into mozilla:main May 20, 2024
6 checks passed
@mathjazz mathjazz deleted the 3219-email-consent branch May 20, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement email consent page
3 participants