Fix sync - updating source string from VCS not working

[haodave]

After source string changed in the git repo, a project sync won't update the source string in the Pontoon project. Tested with a json formatted source file.

[flodolo]

Can you add more details on the issue/behavior you're trying to fix, so that it can be reproduced?

[eemeli]

This needs to include a test case that fails with the current code, but passes with the changes. It's not at all clear what entity change is not getting picked up by the current code.

There are also two parts to this change: How differences are identified, and whether the previous or next entity is used in Entity.objects.bulk_update(). Are both changes required?

[flodolo]

As mentioned, can you clarify the behavior you're trying to fix?

Do you have a specific example (ideally a minimal case) of what is not working and with what content?

[haodave]

As mentioned, can you clarify the behavior you're trying to fix?

Do you have a specific example (ideally a minimal case) of what is not working and with what content?

Yes. I updated the PR description earlier. Here are more details of the behavior:

1. In the source file en.json, update "key": "value" to "key": "value2" with a PR.
2. Sync the Pontoon project.
3. The source string in the Pontoon project translation page should have been changed from value to value2 but it's not.

[mathjazz]

I was able to reproduce the problem in mozilla-l10n/pontoon-test@bcad647.

[eemeli]

@haodave Could you allow edits from maintainers for this branch, or pick up the additional changes from here? I added a test case for this, and applied a couple of other minor fixes. Once that's done, this should be good to merge.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (158597c) to head (f938280).
Report is 1 commits behind head on main.

Additional details and impacted files