Fix advanced search options (missing Fluent strings, CSS) #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
changed the title
flodolo
commented
Jan 5, 2025
| @@ -38,7 +38,7 @@ const SearchOption = ({ | |||
| onToggle(); | |||
| }} | |||
| > | |||
| <i className='fa fa-w'></i> | |||
There was a problem hiding this comment.
Was this meant to be fa-fw (fixed-width)? In any case, the menu seems to work fine without it.
mathjazz
reviewed
Jan 6, 2025
flodolo
force-pushed
the
fix_nits_search
branch
from
0788ed9 to
82745d3
Compare
|
Thanks for the update! Didn't notice this before - I don't get a hover effect on the Apply search options button - neither the text color nor the mouse cursor change. |
|
I think I've fixed it, but I'm not sure I understand the intent of the original code (why was the margin-top changing? Was the extra class ever used?) |
mathjazz
approved these changes
Jan 6, 2025
This was referenced Jan 6, 2025
haodave
pushed a commit
to ScanTrust/pontoon
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
fa-w, see #3507The console is full or React errors when opening the panel. The edit removed a bunch of trailing whitespaces, which I think it's useful to remove anyway.