Add functionality for counting file uploads #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
reviewed
Jan 10, 2025
mathjazz
reviewed
Jan 13, 2025
Factored out notification useEffect hook, added extra tag for badge messages
|
Sorry for the confusion - in https://github.com/mozilla/pontoon/pull/3522/files#r1913781900 and the following comment I meant to communicate that the approach I used in the linked gist is not good enough to be used and we should just factor out a function that checks if we have any notifications to display. |
mathjazz
reviewed
Jan 15, 2025
mathjazz
reviewed
Jan 15, 2025
mathjazz
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3482
This PR adds badge stat counting logic for file uploads.
The communication between frontend and backend is done using the Django messaging framework.
To reproduce results: Head to any resource, click on your profile in the top right, and then click "Download Translations". Save this file in a text editor, and edit 5 translations. Then, head back to the resource, click on your profile again, and click "Upload Translations". Upload the file you edited. Once the upload is complete, you should be awarded the Translation Champion Badge for this action.