Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

Fix #17 Firefox OS 2.0 feeling #18

Open
wants to merge 13 commits into
base: ux
Choose a base branch
from

Conversation

DOMIHERNANDEZ
Copy link

...ns, images; based on Firefox 2.0+ OS"

The integrated concepts of color, typography, shapes, icons, images,
following the guideline Haida .... based on Firefox 2.0+ OS

…aphy, shapes, icons, images; based on Firefox 2.0+ OS"

The integrated concepts of color, typography, shapes, icons, images,
following the guideline Haida .... based on Firefox 2.0+ OS
@nukeador
Copy link
Member

r? @willyaranda

@DOMIHERNANDEZ
Copy link
Author

What happened with the changes I made several days ago PR, maybe have a lot of work .... greetings

@nukeador
Copy link
Member

@willyaranda will review and merge as soon as possible.

@willyaranda willyaranda changed the title Resolved issue #17 "Integrate concepts of color, typography, shapes, ico... Fix #17 Firefox OS 2.0 feeling Nov 15, 2014
@@ -1,25 +1,26 @@
@mixin action-button
+box-sizing(border-box)
+background-image(linear-gradient(bottom, #df351b 0%, #f56b1b 100%))
/*+background-image(linear-gradient(bottom, #df351b 0%, #f56b1b 100%))*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment if it is not needed, please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Willy, I forgot

@nukeador
Copy link
Member

@DOMIHERNANDEZ please apply/commit all suggested changes on your branch so they are automatically updated on this merge request.

Thanks!

@DOMIHERNANDEZ
Copy link
Author

If @nukeador I will, thanks for the feedback and suggestion .... Greetings

@willyaranda
Copy link
Member

@DOMIHERNANDEZ any progress on this? thanks!

@DOMIHERNANDEZ
Copy link
Author

Hi @willyaranda , no I have not even done more commits, only what I have commanded you, but I get to fix tomorrow.
You command further changes or correcting the changes you've told me ...... greetings

@DOMIHERNANDEZ
Copy link
Author

Also I have openwapp to make the necessary evidence comes ..... nome code

@nukeador
Copy link
Member

@DOMIHERNANDEZ did you have time to check the changes @willyaranda suggested?

We need to fix that in order to merge it.

@DOMIHERNANDEZ
Copy link
Author

Hello @nukeador @willyaranda
Sorry for the time, I've had a lot of work and also I had lost my changes because the simulator and delete all apps carpets took on my phone had nothing back, but I'm doing it again, thanks, suddenly I send the modifications

@nukeador
Copy link
Member

@DOMIHERNANDEZ hi again, did you have time to check this? If you don't have time right now it's OK, we can ask other people to help with the UI.

@DOMIHERNANDEZ
Copy link
Author

Hola @nukeador ya estoy mas libre, la verdad no he aportado nada porque
estaba esperando que la App funcionara correctamente, de que sirve una app
con un diseño bueno y que no funcione bien, pero ahora funciona
perfectamente y muchas gracias por arreglar esos errores les agradece la
comunidad, enserio, de hecho iba a mandarte correo pero me ganastes, mira
he perdido una parte del diseño porque borre unos archivos, pero lo he
vuelto a rehacer, y no podia avanzar porque quite temporalmente la app de
mi telefono y tambien he tenido trabajo.
Claro que checare de hecho ya esta en proceso del nuevo diseño inspirado en
el diseño de Firefox Hello espero esta vez lo implementen, muchas gracias y
gracias por tomarme en cuenta y disculpa la demora, saludos mañana mandare
el pull request, gracias

2015-01-29 13:43 GMT-06:00 Nukeador [email protected]:

@DOMIHERNANDEZ https://github.com/DOMIHERNANDEZ hi again, did you have
time to check this? If you don't have time right now it's OK, we can ask
other people to help with the UI.


Reply to this email directly or view it on GitHub
#18 (comment)
.

@Timmaks
Copy link
Contributor

Timmaks commented Jan 30, 2015

please keep it in English here, so we all can follow this....

@DOMIHERNANDEZ
Copy link
Author

Hi @nukeador I'm freer, really have not contributed anything because I
was hoping
the App malfunction, that serves an app with a kind design and
malfunctions, but
now works perfectly and thank you very much to fix these errors is grateful
for the community, really, actually going to send you email but I ganastes,
look I lost a part of the design because deleting some files, but I'm back
to redo, and could not move forward because temporarily remove the app from
my phone and also have had work .
Of course I'll check in fact already in process new design inspired by the
design of Firefox Hello I hope this time we deploy, thank you very much and
thank you for taking me into account and apologizes for the delay, I command
the morning greetings pull request, thanks

2015-01-30 2:09 GMT-06:00 T.M. van den Broek [email protected]:

please keep it in English here, so we all can follow this....


Reply to this email directly or view it on GitHub
#18 (comment)
.

@DOMIHERNANDEZ
Copy link
Author

Hello @willyaranda @nukeador have made commits that were missing and you correct me, thank you greetings

@@ -196,11 +201,11 @@ $conversation-typing-height: 0.6rem
&.image
span.content
padding-right: 7.7rem // 2.7 + 5 rem
min-height: 7.4rem // 7 + 0.4 rem
min-height: 6.2rem // 7 + 0.4 rem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is not right anymore ;)

@DOMIHERNANDEZ
Copy link
Author

Hello friends did what was lacking App design, but I see no change yet, I hope it implemented soon, Greetings

@willyaranda
Copy link
Member

Hi @DOMIHERNANDEZ, could we work on this to a 2.0 openwapp release with the new design?

@willyaranda
Copy link
Member

Ping @DOMIHERNANDEZ

@DOMIHERNANDEZ
Copy link
Author

I do not understand this paragraph @willyaranda (could we work on this to a 2.0 openwapp release with the new design?)

@DOMIHERNANDEZ
Copy link
Author

If I understood well, I guess they want to implement the new design in openwapp 2.0, I'm right, @willyaranda ?

@DOMIHERNANDEZ
Copy link
Author

If so, use styles to customize and deploy the 2.0 openwapp, styles are similar but if you were to miss a shift or any errors or any style rule, keep me informed, sorry esque I have had a lot of work but I'm more free, Greetings

@DOMIHERNANDEZ
Copy link
Author

And if of course you can work @willyaranda

@Timmaks
Copy link
Contributor

Timmaks commented Jul 14, 2015

What is the status of this PR?

@J0WI
Copy link

J0WI commented Jul 19, 2015

You may provide a larger icon (512×512) as recommend: https://developer.mozilla.org/en-US/Apps/Build/Manifest#icons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants