enable pickle entity #1111
Closed
enable pickle entity #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any need to support the The DXF structures have many and often deep linkage, just testing with |
mozman
reviewed
Jun 24, 2024
There was a problem hiding this comment.
To clarify my problem with this change:
When you pickle an entity from a loaded DXF file, the entity contains a reference to this document and the whole DXF document will be included in the data dump.
There was a problem hiding this comment.
Thanks for the clarification, I will continue to learn this issue, try to verify it and keep the changes on my fork for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pickling entity. Since the circular reference of entity.dxf and dxf._entity, causing the fail pickling. To address this, _entity attribute of entity.dxf will be removed before
pickle.dumpand will be rewired whenpickle.load. Also, test function is added to valid the feature.