Allows setting/resetting entity.rgb to None
#1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozman
requested changes
Jun 26, 2024
Thanks for reviewing, I'll update accordingly |
|
Hi, @mozman , could you please review again? |
mozman
reviewed
Jun 27, 2024
| Set RGB true color as (r, g , b) tuple e.g. (12, 34, 56). | ||
| Also allows setting/resetting rgb to None. | ||
| """ | ||
| if rgb is None: |
There was a problem hiding this comment.
This case should raise a TypeError, None is not a valid input or revert everything because the previous version raised the TypeError automatically.
mozman
added a commit
that referenced
this pull request
Jun 27, 2024
- implement DXFGraphic.rgb deleter method. - add tests for DXFGraphic.rgb - update docs and changelog
|
@kkkkkom thanks for the idea, to speed up the process I added all the necessary changes myself |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @mozman , could you please review this minor merge request?
I think we should allow
entity.rgbto be set/reset toNone.Many entity rgbs are initially
Noneby default, and this change will allow users/developers to temporarily set rgb and reset it back without causing an error.pytest has passed clean locally.