Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "old" attribute to the pnum class to indicate pnum changes #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ojhunt
Copy link
Contributor

@ojhunt ojhunt commented Dec 22, 2024

This does not effect the markup, and allows a purely css highlighting model for the changes. We intentionally use the ::before pseudo element to inject the content so that it does not screw up selection of text (e.g. only the "real" text of the change is eligible for selection).

… changes

This does not effect the markup, and allows a purely css highlight model for
the changes. We intentionally use the ::before pseudo element to inject the
content so that it does not screw up selection of text (e.g. only the "real"
text of the change is eligible for selection).
@ojhunt
Copy link
Contributor Author

ojhunt commented Dec 25, 2024

What are your thoughts on this approach? I couldn't work out a way to get similar semantics in latex, my prior approach has been [1.1->1.2]{.pnum} style notation which is kind of ugly

@brevzin
Copy link
Contributor

brevzin commented Jan 1, 2025

For what it's worth, I never change numbers. I just insert fake numbers in the middle. I think this makes it easier to look at the old wording, since the numbers are stable. So if I want to add two paragraphs between the existing 2 and 3, instead of inserting 3 and 4 and renumbering 3 to 5, I'll insert 2a and 2b (or 2+1 and 2+2, or some other cheeky thing).

@ojhunt
Copy link
Contributor Author

ojhunt commented Jan 1, 2025

For what it's worth, I never change numbers. I just insert fake numbers in the middle. I think this makes it easier to look at the old wording, since the numbers are stable. So if I want to add two paragraphs between the existing 2 and 3, instead of inserting 3 and 4 and renumbering 3 to 5, I'll insert 2a and 2b (or 2+1 and 2+2, or some other cheeky thing).

Do you have an example paper? I've been doing [x->y]{.pnum} but I didn't like that either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants