WebXRManager: Further improvements to WebXR layers feature testing. #30282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns brought up in #30112
Description
Further improves the feature detection for Layers in WebXR so that systems that only allow a single projection layer (which is valid according to the spec) can still take the layers path in Three for most content. Thanks for highlighting the issue, @cabanier! Please let me know what you think about this approach?
Also attempts to address the issue with Pico's browser that was brought up in #30112. I do not have Pico hardware, so I can't test, but my theory is that because the code was previously checking for
session
but my patch added a check forsession.enabledFeatures
before that if it was hit this code path prior to a session being created it would display errors in the console. If anyone has access to the Pico browser and could verify that hypothesis, I'd appreciate it!Pushed as a draft initially because I haven't had a chance to test the patch against the Meta browser just yet. I'll take off the draft label once I validate that it works there.