Skip to content

Commit

Permalink
Merge pull request #210 from mrliptontea/replace-node-sass-with-sass
Browse files Browse the repository at this point in the history
Replace node-sass with sass
  • Loading branch information
Grzegorz Rajchman authored Sep 26, 2020
2 parents 8298f58 + 9b9b3ca commit 6bdbd2d
Show file tree
Hide file tree
Showing 14 changed files with 489 additions and 1,263 deletions.
23 changes: 21 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node.js 10.x
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: "10.x"
node-version: 14.x

- name: Install npm dependencies
run: npm ci
Expand All @@ -29,5 +29,24 @@ jobs:
- name: Stylelint
run: npm run lint:sass

build:
runs-on: ubuntu-18.04

strategy:
matrix:
node-version: [10.x, 12.x, 14.x]

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- name: Install npm dependencies
run: npm ci --production

- name: Check build
run: npm run build
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ module.exports = function (grunt) {

sass: {
options: {
implementation: require('node-sass'),
implementation: require('sass'),
sourceMap: false,
outputStyle: 'compressed',
functions: {
'inline-svg': require('sass-inline-svg')('./svg', {
'inline-svg($path, $selectors: null)': require('@liquid-js/sass-inline-svg')('./svg', {
optimize: true,
encodingFormat: 'uri'
})
Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ If you need to customize styles for [Redmine Backlogs][redmine_backlogs] remembe

## Changelog

Latest (master):

* Replaced node-sass with sass.
* Resolved issues with `inline-svg` function in Node 14.x.

v2.12.1 (2020-08-11):

* Fixed #204 - missing context menu icons in Easy WBS plugin.
Expand Down
Loading

0 comments on commit 6bdbd2d

Please sign in to comment.