Skip to content

Commit

Permalink
Merge pull request #168 from mrliptontea/issues-148-150-dashboard-agi…
Browse files Browse the repository at this point in the history
…le-plugins

Fix styling issues in Dashboard and Agile plugins
  • Loading branch information
Grzegorz Rajchman authored Mar 28, 2020
2 parents 6443eba + 5c14dbb commit aaddd2e
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 14 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
name: Run linters

on:
push:
paths:
- src/*
- svg/*
- package*.json
pull_request:
paths:
- src/*
- svg/*
- package*.json
on: push

jobs:
lint:
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ Latest (master):

* Fixed #164: apply responsive overrides more generally
* Fixed #159: wrapping long text in issue attributes.
* Fixed #150: styling for query totals and expander in Agile plugin.
* Fixed #148: full screen view for Dashboard plugin.
* Fixed a "timeline" positioning in issue notes/changes.

v2.9.1 (2020-02-22):
Expand Down
13 changes: 11 additions & 2 deletions src/sass/components/_list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ tr.issue {
}

tr {
span.expander {
span.expander:not(.icon) {
margin-left: 0;
padding-left: 8px;
background-image: inline-svg("plus.svg", (path: (fill: $btn-default-icon-color)));
Expand All @@ -265,7 +265,7 @@ tr {
user-select: none;
}

&.open span.expander {
&.open span.expander:not(.icon) {
background-image: inline-svg("minus.svg", (path: (fill: $btn-default-icon-color)));
}
}
Expand Down Expand Up @@ -682,6 +682,15 @@ table.list.enumerations {
//

.query-totals {
#content & {
margin-top: 0;

@media screen and (min-width: $redmine-responsive-min) {
margin-top: -($line-height-computed * 2 + $btn-padding-vertical);
text-align: right;
}
}

> span {
margin-right: $padding-base-horizontal;

Expand Down
6 changes: 6 additions & 0 deletions src/sass/javascripts/_sidebar-toggler.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
@if $enable-sidebar-toggler {
#main {
position: relative;

// Fix full screen view for dashboard plugin
// https://github.com/jgraichen/redmine_dashboard
@at-root .controller-rdb_taskboard & {
position: static;
}
}

#sidebar {
Expand Down
2 changes: 1 addition & 1 deletion stylesheets/application.css

Large diffs are not rendered by default.

0 comments on commit aaddd2e

Please sign in to comment.