Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the MSRV to Cargo.toml #117

Closed
wants to merge 1 commit into from
Closed

Conversation

danieleades
Copy link

@danieleades danieleades commented Mar 1, 2024

specifying the MSRV in cargo.toml allows cargo to use it when resolving dependencies. Also clippy parses this value and doesn't suggest syntax introduced after the MSRV


This change is Reviewable

@faern faern self-requested a review March 1, 2024 14:30
@faern
Copy link
Member

faern commented Mar 1, 2024

I'll merge this after you rebase it on latest main and it passes CI

@danieleades danieleades closed this Mar 1, 2024
@danieleades
Copy link
Author

I'll merge this after you rebase it on latest main and it passes CI

i've just recreated the PR. seeing some strange behaviour where github isn't picking up the changes correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants