Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include bqn-mode on NonGNU ELPA #21

Open
AndersonTorres opened this issue Feb 20, 2023 · 4 comments
Open

Include bqn-mode on NonGNU ELPA #21

AndersonTorres opened this issue Feb 20, 2023 · 4 comments

Comments

@AndersonTorres
Copy link
Member

Tracking the (sub)issue cited on #1 (comment) by @phikal

@AndersonTorres AndersonTorres changed the title Include bqn-mode in NonGNU ELPA Include bqn-mode on NonGNU ELPA Feb 20, 2023
@phikal
Copy link
Contributor

phikal commented Feb 22, 2023

I haven't gotten around to preparing the patches, but from what I recall my suggestions would be very much along the lines of what I did for gnu-apl-mode: https://github.com/lokedhs/gnu-apl-mode/pull/42/files. AFAIU bqn-mode divered from gnu-apl-mode before these were applied?

@AndersonTorres
Copy link
Member Author

Originally bqn-mode was part of bqn; I just cut it using git-filter-repo, keeping the license.

Before that, it was derived from GNU APL Mode.

@phikal
Copy link
Contributor

phikal commented Feb 22, 2023

I would have to take a closer look at the history, but evidence for my claim can be found here:

bqn-mode still uses macrolet:

(cl-macrolet ((make-insert-functions ()
, while this complication is not only dirty but also more complex than if one were to just use defalias: https://github.com/lokedhs/gnu-apl-mode/pull/42/files#diff-b6ea699a64db70a3d90635a590d322d7e9616f04f0bba4691bf975a3042075f4L189.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Feb 24, 2023

Take your time :)

This is the oldest commit, inherited from old bqn:

3f3c677

@phikal phikal mentioned this issue Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants