Improvements #22
Closed
Improvements #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bqn-mode-map.el: Define insertion commands using defalias instead of a local macro. (bqn-mode-map--command-name): Use "bqn-" as the command prefix. (bqn-mode-map--kbd): Remove function, as it is not needed if the minimum version for bqn-mode is Emacs 26. (bqn-mode-map--make-base): Use `pcase-dolist' (bqn-mode-map-prefix): Improve quoting.
|
@phikal I have included only the first file. The second throws syntax errors I am trying to figure out. |
|
Interestingly it did not complain on my end (Emacs 30), but I have reinspected the commit and changed a few things. |
* bqn-symbols-doc.el (subr-x): Remove dependency. (bqn-symbols-doc--symbol-doc-table): Have the hash table generated at compile time instead of writing out the printed representation. (bqn-symbols-doc--symbols): Replace 'hash-table-keys' with 'maphash'. (bqn-symbols-doc--get-doc): Replace legacy 'when-let' with 'and'.
|
P.S.: I took some liberty to use your patches. I will try to add authorship info as soon as possible. |
|
I will close this, given that I "rebased" it onto the other PR. |
AndersonTorres
added a commit
that referenced
this pull request
Mar 11, 2023
As taken from #22 Co-authored by: Philip Kaludercic <[email protected]>
AndersonTorres
added a commit
that referenced
this pull request
Mar 11, 2023
As taken from #22 Co-authored-by: Philip Kaludercic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some suggestions related to #21. Feel free to change anything if you don't like it, the patch is intentionally opinionated.