Stop audioplayer properly #1032
Conversation
📦 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
|
I have found that FFmpeg causes a memory leak because the processes that pipe the stream don't get killed by stream.kill() unless a video is finished by the player. So they just eat up memory. I can't seem to find a fix. |
MarcoCoreDuo
changed the title
|
I've found the issue. When the audioplayer is paused and then stopped, it will not destory the audio resource unless it plays the remaining silence padding frames (but it can't because it is paused). I replaced stop() with stop(true) when the player is paused. stop(true) will ignore the silence padding frames and destroy the resource and also stop ffmpeg. |
|
🚀 Released in Release v2.9.0. |
While I migrated muse to play-dl I noticed that the FFmpeg processes that are created when seeking in a video or playing multiple livestreams or non-caching videos will still run and download from YouTube in the background.
Now, when a non-caching stream is removed from the player, the corresponding FFmpeg process will also be stopped.Cached streams are still downloaded else the cached audio file will be incomplete.Edit: Audio player is now stopped properly