Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a path traversal vuln. in the file_server emulator #272

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

hun7err
Copy link
Contributor

@hun7err hun7err commented Aug 1, 2016

Unsanitized file path lead to a path traversal vulnerability in the file_server emulator allowing glastopf to read arbitrary files including configuration and the database file.

@glaslos
Copy link
Member

glaslos commented Aug 1, 2016

Nice catch. Should be probably also fixed here: https://github.com/mushorg/glastopf/blob/master/glastopf/modules/classification/request.py#L84
Also check out SNARE and TANNER: https://github.com/mushorg/snare which succeed Glastopf

@glaslos glaslos merged commit 90173ec into mushorg:master Aug 1, 2016
@hun7err
Copy link
Contributor Author

hun7err commented Aug 1, 2016

Thanks! I've just created a PR for request.py as well. Thank you for recommending snare, wouldn't have known about it otherwise :)

@katkad
Copy link
Member

katkad commented Aug 1, 2016

Hello, nice catch.

Can you please share a reproducer ? I am trying to accomplish path traversal in my glastopf.

@hun7err
Copy link
Contributor Author

hun7err commented Aug 2, 2016

Thanks and sorry for the late answer,

http://example.com/%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2f%2e%2e%2fetc/passwd

was a url that worked for me.

@katkad
Copy link
Member

katkad commented Aug 2, 2016

@hun7err thank you very much. nice catch indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants